Partial regex literal support #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a few unfortunate differences from the official parser: 1. Doesn't handle the "unbalanced parentheses" rule, because that would require an external scanner implementation (probably will happen someday!) 2. Doesn't insert an implicit semicolon between the regex and the previous line. This is mostly fine but causes problems with the "Regex builder DSL". 3. Doesn't match opening and closing `#` symbols in multiline regexes, for the same reason as point 1
alex-pinkus
force-pushed
the
regex-literals
branch
from
7357d96 to
00d529f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few unfortunate differences from the official parser:
would require an external scanner implementation (probably will happen
someday!)
previous line. This is mostly fine but causes problems with the "Regex
builder DSL".
#symbols in multiline regexes,for the same reason as point 1