Fix impossible pattern in highlight queries #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the pattern refactor, the highlight query for `for_statement` was never updated, and now refers to a pattern that cannot happen (a `simple_identifier` directly under a `for_statement`). In addition to being wrong, this gets rejected by older versions of `tree-sitter`. Fixes #219
|
Same issue was reported in emacs-tree-sitter/elisp-tree-sitter#240. |
alex-pinkus
added a commit
that referenced
this pull request
Sep 5, 2022
In #221, we fixed a bug where older versions of tree-sitter failed to parse highlight queries because they were impossible. Since we know that some editors use an older version of tree-sitter, it would be prudent to test against it in CI.
alex-pinkus
added a commit
that referenced
this pull request
Sep 5, 2022
In #221, we fixed a bug where older versions of tree-sitter failed to parse highlight queries because they were impossible. Since we know that some editors use an older version of tree-sitter, it would be prudent to test against it in CI.
alex-pinkus
added a commit
that referenced
this pull request
Sep 5, 2022
In #221, we fixed a bug where older versions of tree-sitter failed to parse highlight queries because they were impossible. Since we know that some editors use an older version of tree-sitter, it would be prudent to test against it in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the pattern refactor, the highlight query for
for_statementwas never updated, and now refers to a pattern that cannot happen (asimple_identifierdirectly under afor_statement). In addition to being wrong, this gets rejected by older versions oftree-sitter.Fixes #219