Non-persistent background script #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key changes: * Use local storage instead of messaging to enable/disable modification * Ensure config has been loaded before being used in request event handler
All versions since 0.5 (published January 2019) did that cleanup, so no current users should still have that. And if anyone reactivates an ancient browser profile it shouldn't cause trouble either.
Previously an unset "mod_enable" value in local storage would lead to an empty button.
There's nothing async in it in the current form, so the result is only an unnecessary "await" in the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also called "Event Page". See this Mozilla blog entry for the advantages. I'm not sure if there's a lot of resource saving in this specific case: Expressions have to be loaded on resume, which is a it's memory saving vs. CPU load trade-off. But the crash recovery is desirable, and it's a step towards Manifest v3 that I can take now.
Summary of the required changes: