feat(airbyte-ci): re-publish connector image if --pre-release #55262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bnchrch
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This makes it so that when you merge a pull request with a connector change that does NOT have a version increment in it, but you publish it manually with
--pre-releaseflag, it will overwrite the connector image in the registry.It's built to support
metadata.data.ab_internal.requireVersionIncrementsInPullRequests == Falseworkflow for @airbytehq/move-destinations so they can mark connectors as "hey don't require version check please" and they can use master as their dev branch, only occasionally pushing up version increments.TODO
There are several related tests in other flows that rely on republishing that need to be cleaned up