-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-klaviyo contribution from tuday2 #55249
base: master
Are you sure you want to change the base?
source-klaviyo contribution from tuday2 #55249
Conversation
@tuday2 is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
The only thing I couldn't figure out is their API requires "Klaviyo-API-Key " to be in the API key field. I suppose we could just add it to the directions to prepend that onto their api key .... it works like this: "Klaviyo-API-Key pk_00000000000000" where pk_00000000000000 is the API key |
/bump-version type="minor" changelog="fix missing custom fields"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough internals of Klaviyo specifically, but this is great work. Thank you @tuday2 and @marcosmarxm.
Co-authored-by: Natik Gadzhi <natik@respawn.io>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A workaround can be to make an additional stream that is a copy of the first one, and change the field path there, then merge data downstream. |
Ok that seems straightforward. I will work on that in the short term. |
What
This PR updates source Klaviyo (source-klaviyo).
The contributor provided the following description of the change:
Fixed errors when forking, many fields were custom and not able to be "tested" preventing the ability to publish contributions. No functional changes made.
Reviewer checklist
bump-version
Airbyte-CI command locally to update the version of the connector according to the versioning guidelines. AddbreakingChanges
to metadata if necessary./format-fix
to resolve any formatting errors