Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-klaviyo contribution from tuday2 #55249

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tuday2
Copy link

@tuday2 tuday2 commented Mar 7, 2025

What

This PR updates source Klaviyo (source-klaviyo).

The contributor provided the following description of the change:

Fixed errors when forking, many fields were custom and not able to be "tested" preventing the ability to publish contributions. No functional changes made.

Reviewer checklist

  • Resolve any merge conflicts and validate file diffs (make sure the PR only includes changes intended by the contributor)
  • After reviewing the changes, run the bump-version Airbyte-CI command locally to update the version of the connector according to the versioning guidelines. Add breakingChanges to metadata if necessary.
  • Ensure connector docs are up to date with any changes
  • Run /format-fix to resolve any formatting errors
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Mar 7, 2025

@tuday2 is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2025

CLA assistant check
All committers have signed the CLA.

@tuday2
Copy link
Author

tuday2 commented Mar 7, 2025

The only thing I couldn't figure out is their API requires "Klaviyo-API-Key " to be in the API key field. I suppose we could just add it to the directions to prepend that onto their api key .... it works like this: "Klaviyo-API-Key pk_00000000000000" where pk_00000000000000 is the API key

@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 7, 2025

/bump-version type="minor" changelog="fix missing custom fields"

Bump Version job started... Check job output.

✅ Changes applied successfully. (e03d95b)

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough internals of Klaviyo specifically, but this is great work. Thank you @tuday2 and @marcosmarxm.

@natikgadzhi
Copy link
Contributor

@agarctfi would you like to pair on reviewing this with @tolik0 next week?

Co-authored-by: Natik Gadzhi <natik@respawn.io>
@tuday2
Copy link
Author

tuday2 commented Mar 11, 2025

@agarctfi would you like to pair on reviewing this with @tolik0 next week?

How long would this take? Also do you know if we can pull 2 top level "field-paths"? That's the issue... and i know me and all the users of this need that attribution information.

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 11:48pm

@natikgadzhi
Copy link
Contributor

How long would this take? Also do you know if we can pull 2 top level "field-paths"?

A workaround can be to make an additional stream that is a copy of the first one, and change the field path there, then merge data downstream.

@tuday2
Copy link
Author

tuday2 commented Mar 13, 2025

How long would this take? Also do you know if we can pull 2 top level "field-paths"?

A workaround can be to make an additional stream that is a copy of the first one, and change the field path there, then merge data downstream.

Ok that seems straightforward. I will work on that in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/klaviyo
Projects
Development

Successfully merging this pull request may close these issues.

[source klaviyo] Missing fields latest release
6 participants