-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link to data type test Java code #55213
Open
apd-bbrewington
wants to merge
2
commits into
airbytehq:master
Choose a base branch
from
apd-bbrewington:apd-bbrewington/fix-broken-java-test-links-in-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix broken link to data type test Java code #55213
apd-bbrewington
wants to merge
2
commits into
airbytehq:master
from
apd-bbrewington:apd-bbrewington/fix-broken-java-test-links-in-docs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@apd-bbrewington is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
marcosmarxm
approved these changes
Mar 5, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@marcosmarxm heads up, post your approval I went ahead and lumped a minor Markdown formatting issue into this as well |
/approve-and-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Noticed a broken link in Oracle docs that was pointing to an old naming scheme of integration test Java code. Searched the repo for similarly named file and noticed MS SQL had same issue
For reference:
How
Pointed URL's to the current Java file
<db_name>SourceDatatypeTest.java
Review guide
n/a
User Impact
Working links 😎
Can this PR be safely reverted and rolled back?