source-amazon-seller-partner: Add VendorOrdersStatus stream #55195
Conversation
|
@GtheSheep is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
GtheSheep
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
@artem1205 can pretty please review this? |
...egrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/manifest.yaml
Outdated
Show resolved
Hide resolved
| datetime: "{{ format_datetime( max(config.get('replication_start_date', (now_utc() - duration('P730D')).strftime('%Y-%m-%dT%H:%M:%SZ') ), (now_utc() - duration('P730D')).strftime('%Y-%m-%dT%H:%M:%SZ')), '%Y-%m-%dT%H:%M:%SZ') }}" | ||
| datetime_format: "%Y-%m-%dT%H:%M:%SZ" |
There was a problem hiding this comment.
From docs:
Warning
Returns purchase order statuses based on the filters that you specify. Date range to search must not be more than 7 days.
Please check it and cover with the test if possible
There was a problem hiding this comment.
Is that not covered by the step: "P7D" arg? Then the above is just the start date for the initial run?
There was a problem hiding this comment.
Is that not covered by the step: "P7D" arg?
not really. step_size is used during slicing, e.g.
we have start_date == 1 February, end_date=today 5 March, step= 7 days. so our datetimeCursor will create roughly 5 slices (1-7 Feb, 7-14 Feb, 14-21 Feb ....) and will read them concurrently.
Then the above is just the start date for the initial run?
Exactly, we'll have to check that start date is not more than 7 days in the past (and forcefully move if it is)
There was a problem hiding this comment.
The docs seem to be referring to the start/end date window size per request, rather than the availability to lookback? It's referred to the same way in purchaseOrders
There was a problem hiding this comment.
I think you are correct @GtheSheep. The doc seems to be referring to each request, not the lookback. This looks to be good to go! :)
GtheSheep
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
When I click through the "Connectors CI tests", all seems fine? |
GtheSheep
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
CI requires manual approval of maintainers after each commit from a non-member of the org, security-shchmecurity. Kicked it off again. |
|
@agarctfi give this a review to ;) |
|
@artem1205 @natikgadzhi - anything I can do here at the moment? thanks |
GtheSheep
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
agarctfi
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
What
Add VendorOrdersStatus stream to source Amazon Seller Partner, closes #46331
How
Added stream and testing to mimic VendorOrders stream
Review guide
manifest
test_vendor_status_orders.py
others...
It's quite difficult to know if I've covered all relevant files? Please guide me if not! 😅
User Impact
New stream available for Amazon Seller Partner
Can this PR be safely reverted and rolled back?