Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat(source-microsoft-sharepoint): initial changes for ACLs DO NOT MERGE! #54175

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

aldogonzalez8
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 commented Feb 20, 2025

What

Implemented the SourceMicrosoftSharePointStreamPermissionsReader class to handle file permissions and identity management for the Microsoft SharePoint source connector. This implementation extends the AbstractFileBasedStreamPermissionsReader class and reuses functionality from the existing SourceMicrosoftSharePointStreamReader.

Here is a doc about the Identitities and File permissions implementation

How

  • Created new class SourceMicrosoftSharePointStreamPermissionsReader that implements the required abstract methods from AbstractFileBasedStreamPermissionsReader
  • Reused authentication logic by leveraging the existing SourceMicrosoftSharePointClient class
  • Implemented key methods for permissions handling:
    • identities_schema
    • file_permissions_schema
    • get_file_acl_permissions
    • get_file_permissions
    • load_identity_groups
  • Maintained consistent authentication and API interaction patterns with the main stream reader

Review guide

  1. source_microsoft_sharepoint/stream_permissions_reader.py - New file implementing the permissions reader
    • Authentication handling using SourceMicrosoftSharePointClient
    • File permissions retrieval and processing
    • Identity group management

User Impact

  • Users can now access and manage file permissions and identity information from Microsoft SharePoint
  • No negative side effects as this is an additive feature that maintains existing functionality

Can this PR be safely reverted and rolled back?

  • YES 💚

@aldogonzalez8 aldogonzalez8 self-assigned this Feb 20, 2025
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 4:27pm

@aldogonzalez8 aldogonzalez8 changed the title feat(source-microsoft-sharepoint): initial changes for ACLs DO NOT MERGE! ✨feat(source-microsoft-sharepoint): initial changes for ACLs DO NOT MERGE! Feb 28, 2025
…fallback to user if member is not recognized for get group members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants