-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨feat(source-microsoft-sharepoint): initial changes for ACLs DO NOT MERGE! #54175
Draft
aldogonzalez8
wants to merge
33
commits into
master
Choose a base branch
from
aldogonzalez8/source-microsoft-sharepoint/add-acl-identities
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
✨feat(source-microsoft-sharepoint): initial changes for ACLs DO NOT MERGE! #54175
aldogonzalez8
wants to merge
33
commits into
master
from
aldogonzalez8/source-microsoft-sharepoint/add-acl-identities
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…add-acl-identities
2 tasks
…fallback to user if member is not recognized for get group members
…methods to get identities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implemented the
SourceMicrosoftSharePointStreamPermissionsReader
class to handle file permissions and identity management for the Microsoft SharePoint source connector. This implementation extends theAbstractFileBasedStreamPermissionsReader
class and reuses functionality from the existingSourceMicrosoftSharePointStreamReader
.Here is a doc about the Identitities and File permissions implementation
How
SourceMicrosoftSharePointStreamPermissionsReader
that implements the required abstract methods fromAbstractFileBasedStreamPermissionsReader
SourceMicrosoftSharePointClient
classidentities_schema
file_permissions_schema
get_file_acl_permissions
get_file_permissions
load_identity_groups
Review guide
source_microsoft_sharepoint/stream_permissions_reader.py
- New file implementing the permissions readerSourceMicrosoftSharePointClient
User Impact
Can this PR be safely reverted and rolled back?