-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Instagram: updating media and mediainsights fields #53214
base: master
Are you sure you want to change the base?
Source Instagram: updating media and mediainsights fields #53214
Conversation
Someone is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
Can you provide an issue links to Instagram documentation page showing these fields? |
Sure @marcosmarxm |
/format-fix
|
@natikgadzhi @DanyloGL please let me know if anything pending at my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but we should do a regression test or a progressive rollout, this is pretty sensitive.
And we should bump the version, I'll try this now.
@@ -61,6 +61,16 @@ | |||
} | |||
} | |||
}, | |||
"boost_eligibility_info": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY for regenerating ERDs too!
/bump-version type="patch" changelog="New fields in media and mediainsights"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanyloGL take this for a regression test please!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Can't run regression as the branch is not in Airbyte repo. Will try to find out the way how to test it. |
thanks for the update @natikgadzhi , I have created two more streams, will raise new PR once this is merged. |
@hromit, I've made several regression runs and them showed that stream |
Hey @DanyloGL, Thanks for the update. My changes are not condition based changes. All I did is added fileds available in the API which were not present in the streams. So not so sure about the reason for your concern. Ideally the changes would have no impact on the number of records fetched. cc: @natikgadzhi |
Hey @DanyloGL , @natikgadzhi It would be great if you could let me know that how are you running the regression or give me more insights about it. When I ran tests on my local, all tests were passing and i did not see any reduction in the number of records as such. |
Hi! We are running the same regression tests on current prod connector version and on new version. After this results are compared. In this case mentioned stream on your connector version retrieves less data then prod version. |
Hi @DanyloGL Thanks for the response. I connected with my two instagram accounts, I see no difference in the total number of records for media and media_insights. I also tried to match with the original version of the connector & still there was no difference. Now looks like, to resolve this I need to run regression in my local system. Please suggest if there is some other way around. It would be really great if you could you please help me out, how to reproduce this in our local environment. Currently with the below command, when I am using the test suite in my our local, it is skipping regression test.
It would be really great if you could point me to some resource about how to perform regression testing at local. Is there some specific params needs to be passed while running test airbyte-ci test. I am also trying to figure out, what account it connects for the regression testing. Would i able to connect to same account and check the regression records count. |
Could you help me move forward here. |
What
Updating media & mediainsights stream with new available fields.
How
Updated Manifest.yaml with new fields & updated schema.
Review guide
manifest.yaml, media_insights.json
updated unit test cases
User Impact
Can this PR be safely reverted and rolled back?