Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Installer: Provide reliable installation path #422

Open
Okeanos opened this issue Jan 23, 2022 · 0 comments
Open

Windows Installer: Provide reliable installation path #422

Okeanos opened this issue Jan 23, 2022 · 0 comments

Comments

@Okeanos
Copy link

Okeanos commented Jan 23, 2022

When installing any of the Adoptium versions on Windows a version specific (including patch level) path is used by default:
Screenshot 2022-01-23 at 12 08 28

If I understand e.g. #88 correctly then path variables and registry keys are updated on update. That's fine and a good beginning, however, insufficient in some use cases. For instance Maven Toolchains are an optional, manual setup that tell Maven where to find major versions of JDKs that a user has installed. The paths are essentially hardcoded in the declaration file. So if I want my toolchains to always point to the latest JDK of a major release I'll manually have to update that after installation of the patch version.

I therefore propose to shorten the default installation path of Adoptium to the major version only, e.g. C:\Program Files\Eclipse Adoptium\jdk-11.0.14.9-hotspot becomes C:\Program Files\Eclipse Adoptium\jdk-11-hotspot. This would also align with macOS for example where the path is usually /Library/Java/JavaVirtualMachines/temurin-11.jdk.

On linux the .deb path is also major release only:

$ update-java-alternatives -l
temurin-11-jdk-amd64           1111       /usr/lib/jvm/temurin-11-jdk-amd64
temurin-17-jdk-amd64           1161       /usr/lib/jvm/temurin-17-jdk-amd64

I guess this also relates to #352 in some way.

adipiciu added a commit to adipiciu/adoptium_installer that referenced this issue Jan 7, 2024
Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
adipiciu added a commit to adipiciu/adoptium_installer that referenced this issue Jan 7, 2024
Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
adipiciu added a commit to adipiciu/adoptium_installer that referenced this issue Jan 7, 2024
Changed INSTALLDIR to fixed path to fix adoptium#422 and adoptium#600
adipiciu added a commit to adipiciu/adoptium_installer that referenced this issue Jan 7, 2024
Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
Okeanos pushed a commit to Okeanos/adoptium-installer that referenced this issue Aug 23, 2024
Signed-off-by: adipiciu <13155063+adipiciu@users.noreply.github.com>
Okeanos added a commit to Okeanos/adoptium-installer that referenced this issue Aug 23, 2024
Okeanos added a commit to Okeanos/adoptium-installer that referenced this issue Aug 23, 2024
…er>-<jre|jdk>`

See adoptium#789 (comment) for
details.

Fixes adoptium#422

Signed-off-by: Nikolas Grottendieck <git@nikolasgrottendieck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant