Setup build environment with Make. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actualdankcoder
requested changes
Jan 17, 2022
There was a problem hiding this comment.
I think the linux binary salmon is better off going into the releases section rather than being included in the source folder itself
|
Looks like that was included by mistake. Will remove. |
|
Another thing, the binary is quite large for it's relatively small codebase. Can anything be done to optimize it or is that not a priority right now? |
actualdankcoder
approved these changes
Jan 17, 2022
It's something that has to do with the web development library gin, it's not something we can tackle at this stage but I don't see the file size growing any exponentially larger in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the last commit typo, it's late..