Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a broken link to actions/upload-a-build-artifact in dotnet-desktop.yml #1074

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

tmash06
Copy link
Contributor

@tmash06 tmash06 commented Sep 5, 2021

A link to actions/upload-artifact@v2 (https://github.com/marketplace/actions/upload-artifact) in dotnet-desktop.yml has been broken.

This PR fixes this issue by replacing it with https://github.com/marketplace/actions/upload-a-build-artifact.

@tmash06 tmash06 requested a review from a team as a code owner September 5, 2021 05:40
@tmash06 tmash06 changed the title Fixed a broken link to actions/upload-a-build-artifact in dotnet-desktop.yml Fix a broken link to actions/upload-a-build-artifact in dotnet-desktop.yml Sep 5, 2021
Copy link
Member

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshmgross joshmgross merged commit b33f57d into actions:main Sep 9, 2021
ashwinsangem pushed a commit that referenced this pull request Sep 16, 2021
* Secure workflows (#1) (#1072)

* Restrict permissions for the GITHUB_TOKEN in .github/workflows/label-feature.yml

* Restrict permissions for the GITHUB_TOKEN in .github/workflows/label-support.yml

* Restrict permissions for the GITHUB_TOKEN in .github/workflows/stale.yml

* Restrict permissions for the GITHUB_TOKEN in .github/workflows/sync_ghes.yaml

* Restrict permissions for the GITHUB_TOKEN in .github/workflows/validate-data.yaml

Co-authored-by: Step Security <bot@stepsecurity.io>

Co-authored-by: step-security[bot] <89328102+step-security[bot]@users.noreply.github.com>
Co-authored-by: Step Security <bot@stepsecurity.io>

* Directory for deployments (#1071)

* moving deployment templates

* including deployment directory in scripts

* validate categories script init

* introducing scout

* introducing workflow

* Update validate-categories.yaml

* Update validate-categories.yaml

* Update validate-categories.yaml

* Update validate.rb

* Update validate.rb

* Update validate.rb

* Update validate.rb

* Update validate-categories.yaml

* Update validate-categories.yaml

* Update validate-categories.yaml

* Update validate.rb

* Update validate-categories.yaml

* Update validate-categories.yaml

* Create test_comment.yaml

* rename

* using [enter]

* testing newline

* test

* setting up variable

* using echo -e

* using join

* testing space space new line

* setting multi line in echo

* removing checkout

* setting rows-generator

* fixing error

* using join

* commit

* Update test_comment.yaml

* escaping pipe

* printing debug line

* using %0A

* Update validate-categories.yaml

* Update validate.rb

* Update validate.rb

* removing debug

* removing variable

* Update validate.rb

* Update validate-categories.yaml

* Validate categories comment on pr (#32)

* reverting deployment directory

* checking for output

* Categories validation two workflows (#34)

comment on pr in a separate workflow

* Categories validation two workflows (#35)

using right dir name

* Categories validation two workflows (#36)

.

* Categories validation two workflows (#37)

fixing typo

* adding if conditions

* adding try catch

* using console instead of echo

* equating to upstream

* moving deployment templates

* add codeql workflow to ghes

* restoring from main (#1078)

* Revert "add codeql workflow to ghes branch"

* add codeql workflow to ghes

* only run ghes sync checks on YML files

* only check nwo of supported actions

* added `React` and `Angular` as categories to node (#1084)

* Fixed a broken link to actions/upload-a-build-artifact in dotnet-desktop.yml. (#1074)

Co-authored-by: Josh Gross <joshmgross@github.com>

* Added support for Java Frameworks, Spring and JSF to CI Templates. (#1087)

* Update OpenShift workflow to use GHCR by default (#6)

- Simplifies required configuration since a registry account is now
  optional
- Update a variety of comments
- Use tools-installer to install oc
- Other small changes towards a better UX

Signed-off-by: Tim Etchells <tetchel@gmail.com>

* Update github-script major version

Co-authored-by: John Bohannon <imjohnbo@github.com>

* Addressing review comments - Renaming template and updating setup-ruby action version (#1086)

* renaming template and updating setup-ruby action version

* renaming rubyrails files

* renaming rails files

* Addition to categories to python templates (#1088)

* addition to categories for python-app template

* adding categories to pylint template

* adding categories to python-package template

Co-authored-by: Ashwin Sangem <ashwinsangem@github.com>

* Adding category in the template property file (#1092)

* adding category in the template property file

* added category on ruby template

* add `makefile` template (#1093)

Co-authored-by: Ashwin Sangem <ashwinsangem@github.com>

* added prefix `npm-` (#1097)

* support `AspNetCore` and `DotNetConsole` (#1096)

Co-authored-by: Ashwin Sangem <ashwinsangem@github.com>

* add `Continuous integration` to makefile props (#1100)

Co-authored-by: Varun Sharma <varunsh@stepsecurity.io>
Co-authored-by: step-security[bot] <89328102+step-security[bot]@users.noreply.github.com>
Co-authored-by: Step Security <bot@stepsecurity.io>
Co-authored-by: Aparna Ravindra <82894348+aparna-ravindra@users.noreply.github.com>
Co-authored-by: Nick Fyson <nickfyson@github.com>
Co-authored-by: Ninad Kavimandan <ninadkavimandan@github.com>
Co-authored-by: tmash06 <tmash06@gmail.com>
Co-authored-by: Josh Gross <joshmgross@github.com>
Co-authored-by: Tim Etchells <tetchel@gmail.com>
Co-authored-by: Tim Etchells <tetchell@redhat.com>
Co-authored-by: John Bohannon <imjohnbo@github.com>
Co-authored-by: Shubham Tiwari <64764738+tiwarishub@users.noreply.github.com>
@tmash06 tmash06 deleted the fix-broken-link-dotnet-desktop branch September 19, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants