Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the RangeControl example code. #69591

Merged

Conversation

shimotmk
Copy link
Contributor

What?

Modify the RangeControl example code.

Related: #40535

Why?

The state of RangeControl takes a number.

The default value of true is not good for an example, so I changed it.

The variable name of isChecked is changed to value because it expects a boolean.

Screenshots or screencast

Before After
before after

@shimotmk shimotmk requested a review from ajitbohra as a code owner March 17, 2025 09:56
Copy link

github-actions bot commented Mar 17, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Mar 18, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Perhaps forgot to fix the code when it was copied from some other component's code 😄

@t-hamano t-hamano added [Package] Components /packages/components props-bot Adding this label triggers the Props Bot workflow for a PR. labels Mar 18, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 18, 2025
@t-hamano t-hamano merged commit f796b43 into WordPress:trunk Mar 18, 2025
68 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 18, 2025
@shimotmk shimotmk deleted the fix/components-rangecontrol--docs branch March 18, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants