Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the protected interface class list #206

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Specify the protected interface class list #206

merged 3 commits into from
Oct 6, 2021

Conversation

reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Oct 5, 2021 •
edited by pr-preview bot
Loading

@reillyeon reillyeon requested a review from jyasskin October 5, 2021 00:07
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 5, 2021
@reillyeon @chromium-wpt-export-bot
usb: Upstream protected interface class tests
500d729 
The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Oct 5, 2021
Merged
jyasskin
jyasskin approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits:

index.bs
@@ -645,7 +645,7 @@ steps <a>in parallel</a>:
2. Check that the algorithm was triggered while the [=relevant global object=]
had a <a>transient activation</a>. Otherwise, <a>reject</a> |promise| with
a {{SecurityError}} and abort these steps.
3. Set <code>|status|.{{PermissionStatus/state}}</code> to `"ask"`.
3. Set <code>|status|.{{PermissionStatus/state}}</code> to <code>"ask"</code>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, you could add

Markup Shorthands: markdown yes

to the initial <pre class="metadata">. The last time I thought about a complete configuration, I used

Complain About: accidental-2119 yes, missing-example-ids yes
Markup Shorthands: markdown yes, css no
Assume Explicit For: yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised I didn't have Markdown enabled but then I remembered that I had gotten thoroughly frustrated by it at some point earlier when editing the specification and made the decision to turn it off. Let me land this as is and then consider whether I want to do that refactoring.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
reillyeon and others added 2 commits October 5, 2021 11:39
@reillyeon @jyasskin
Apply suggestions from @jyasskin
a1efc5a 
Co-authored-by: Jeffrey Yasskin <jyasskin@chromium.org>
@reillyeon
Re-trigger PR checks
3b99c55
@reillyeon reillyeon merged commit 7d7fab1 into main Oct 6, 2021
@reillyeon reillyeon deleted the protected_interfaces branch October 6, 2021 16:05
github-actions bot added a commit that referenced this pull request Oct 6, 2021
@reillyeon @github-actions
Specify the protected interface class list (#206)
12b705c 
SHA: 7d7fab1
Reason: push, by @reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 6, 2021
@reillyeon @github-actions
Specify the protected interface class list (#206)
a3ee5e4 
SHA: 7d7fab1
Reason: push, by @reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 6, 2021
@reillyeon @chromium-wpt-export-bot
usb: Upstream protected interface class tests
9c8e34c 
The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 6, 2021
@reillyeon @chromium-wpt-export-bot
usb: Upstream protected interface class tests
52c0293 
The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}
pull bot pushed a commit to FreddyZeng/chromium that referenced this pull request Oct 7, 2021
@reillyeon
usb: Upstream protected interface class tests
98904d8 
The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 14, 2021
@reillyeon @moz-wptsync-bot
Bug 1734062 [wpt PR 31106] - usb: Upstream protected interface class …
93a4a83 
…tests, a=testonly

Automatic update from web-platform-tests
usb: Upstream protected interface class tests

The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}

--

wpt-commits: 52c02939d0a4a92f7a05c99f82e8113733c7d7a7
wpt-pr: 31106
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Oct 14, 2021
@reillyeon @moz-wptsync-bot
Bug 1734062 [wpt PR 31106] - usb: Upstream protected interface class …
3fbb553 
…tests, a=testonly

Automatic update from web-platform-tests
usb: Upstream protected interface class tests

The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}

--

wpt-commits: 52c02939d0a4a92f7a05c99f82e8113733c7d7a7
wpt-pr: 31106
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
@reillyeon @Gabisampaio
usb: Upstream protected interface class tests
8de3312 
The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@reillyeon @copybara-github
usb: Upstream protected interface class tests
486731b 
The set of protected interface classes has been specified in
WICG/webusb#206.

Change-Id: Ie788fdb2dc4530d424d7a3c92850958cf477f20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203109
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928748}
NOKEYCHECK=True
GitOrigin-RevId: 98904d89080c1fbdd3d3d77e89e6327c0d4fdd68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyasskin jyasskin jyasskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please clarify which types of devices can be accessed via WebUSB
2 participants
@reillyeon @jyasskin