Skip to content

[WIP] Add Ninja Forms support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zackkatz
Copy link
Contributor

There are items that aren't implemented yet.

Some background:

DataKit does filtering, searching, and sorting through our own single REST endpoint. We then use native plugin functions to generate the response using the get_data_ids() method.

I spent many hours trying to pass through the search and filter settings into the Ninja Forms REST API handler (using rest_do_request()), but I kept hitting walls. I then tried cloning over some methods from Ninja Forms into the class, but the amount of complexity that introduced was unacceptable.

I decided to fall back on a very basic CPT search that was inspired by the Ninja Forms code…and then ask for assistance.

Things that still need to be implemented

  • Sorting by field (ASC/DESC)
  • Searching all fields (as implemented in the NF Submissions screen)
  • Replace get_data_ids() with a native function that allows passing search values
    • Update the count() method, when implemented
  • Verify capability for deleting submissions (is delete_posts the correct capability to check?)

There are items that aren't implemented yet. I will details the reasons why in the PR and hopefully get them resolved with some support from the NF team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant