Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are items that aren't implemented yet.
Some background:
DataKit does filtering, searching, and sorting through our own single REST endpoint. We then use native plugin functions to generate the response using the
get_data_ids()
method.I spent many hours trying to pass through the search and filter settings into the Ninja Forms REST API handler (using
rest_do_request()
), but I kept hitting walls. I then tried cloning over some methods from Ninja Forms into the class, but the amount of complexity that introduced was unacceptable.I decided to fall back on a very basic CPT search that was inspired by the Ninja Forms code…and then ask for assistance.
Things that still need to be implemented
get_data_ids()
with a native function that allows passing search valuescount()
method, when implementeddelete_posts
the correct capability to check?)