Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize .vercelignore configuration #366

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Optimize .vercelignore configuration #366

merged 1 commit into from
Jun 10, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Jun 10, 2021 •
edited
Loading

Ignore more useless files + don't ignore yarn.lock

Before

image

image

After

image

image

We could also optimize even more by ignoring all storybook-related files when deploying the app (.storybook and src/stories). But that seems like an overhead of configuration complexity which would yield very little gain.

@github-actions github-actions bot temporarily deployed to storybook June 10, 2021 08:22 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging June 10, 2021 08:22 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 391c091 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-6bid4nslv-unly-oss.vercel.app
Deployment aliases (2): nrn-v2-mst-aptd-at-lcz-sty-c1-preview.vercel.app, nrn-v2-mst-aptd-at-lcz-sty-c1-optimize-vercel-ignore.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 391c091 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-k5m8hsu06-unly-oss.vercel.app
Deployment aliases (1): nrn-v2-mst-aptd-at-lcz-sty-storybook.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 391c091 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-k5m8hsu06-unly-oss.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 391c091 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-6bid4nslv-unly-oss.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review June 10, 2021 08:35
@Vadorequest Vadorequest linked an issue Jun 10, 2021 that may be closed by this pull request
Use .vercelignore better #299
Closed
@Vadorequest Vadorequest merged commit b0dd34f into v2-mst-aptd-at-lcz-sty Jun 10, 2021
@Vadorequest Vadorequest deleted the optimize-vercel-ignore branch June 10, 2021 08:36
Vadorequest added a commit that referenced this pull request Jun 10, 2021
@Vadorequest
Optimize .vercelignore configuration (from #366, modified)
ec618be
@Vadorequest Vadorequest mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use .vercelignore better
1 participant
@Vadorequest