Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await Vercel deployment to be ready before running E2E #221

Merged
merged 23 commits into from
Dec 19, 2020
Merged

Await Vercel deployment to be ready before running E2E #221

merged 23 commits into from
Dec 19, 2020

Conversation

Demmonius
Copy link
Collaborator

@Demmonius Demmonius commented Dec 11, 2020 •
edited by Vadorequest
Loading

https://app.asana.com/0/1136912812619441/1198898897367222

Use our recently released GitHub action https://github.com/UnlyEd/github-action-await-vercel to wait for the Vercel deployment to reach status=READY before running E2E/LH.

See #184 for more details.

Fixes #184
Closes #184

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 81c54cb successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-5d2sawa91.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 81c54cb previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-5d2sawa91.vercel.app

Vadorequest
Vadorequest requested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@Vadorequest Vadorequest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Vadorequest Vadorequest changed the title Implement our own action to wait a vercel deployment Await Vercel deployment to be ready before running E2E Dec 11, 2020
@Demmonius
Copy link
Collaborator Author

Fixed !
Before any merge, I will have to put the same code in the production file.
And we may change the version if you update the action. So let's wait for the review of the action ? :)

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2ab023b successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-gxanpbe59.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2ab023b previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-gxanpbe59.vercel.app

@Vadorequest
Copy link
Member

Agreed, let's first focus on the Action itself, then merge this PR. But it looks good already :)

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 2ab023b successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-gxanpbe59.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 2ab023b previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-gxanpbe59.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 4043ab9 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-kiwnw9p42.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit de0550f successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-7s2fiyd60.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit de0550f previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-7s2fiyd60.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 75180cb successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-c0cxm3b5u.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 75180cb previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-c0cxm3b5u.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit e80c4e6 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-kvhg314dx.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit b1d63e5 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-4g0sq57qj.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 5467fa7 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-6jsq1jn54.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 5467fa7 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-6jsq1jn54.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit b1d63e5 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-9xpmpium6.vercel.app
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 69548b1 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-limntpelk.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 69548b1 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-limntpelk.vercel.app

@Demmonius
Copy link
Collaborator Author

@Vadorequest if our action is fine for you, I think we can merge this. I just updated for the last release :)

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 87b73aa successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-4kx1vjrrb.vercel.app
Deployment aliased as v2-mst-aptd-at-lcz-sty.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit cac6324 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-m6tsberpq.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 6f474ec successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-zkr15a25s.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 6f474ec previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-zkr15a25s.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 87b73aa previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-zkr15a25s.vercel.app
Download artifacts (screenshots + videos) from checks section

@github-actions
Copy link

❌  E2E tests FAILED for commit cac6324 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-zkr15a25s.vercel.app
Download artifacts (screenshots + videos) from checks section

@Vadorequest Vadorequest marked this pull request as ready for review December 19, 2020 16:09
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 78c8f19 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-28hx0jtk8.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 78c8f19 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-28hx0jtk8.vercel.app

@Vadorequest Vadorequest linked an issue Dec 19, 2020 that may be closed by this pull request
Sometimes, E2E tests fail because they're testing the Vercel domain instead of the deployment domain #184
Closed
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 229132b successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-fytrkmo13.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-c1-implement-c.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 229132b previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-fytrkmo13.vercel.app

@Vadorequest Vadorequest merged commit e8d68f9 into v2-mst-aptd-at-lcz-sty Dec 19, 2020
@Vadorequest Vadorequest deleted the implement-custom-wait-action branch December 19, 2020 16:30
Vadorequest added a commit that referenced this pull request Dec 19, 2020
@Demmonius @Vadorequest
Await Vercel deployment to be ready before running E2E (#221)
94d618b 
Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vadorequest Vadorequest Vadorequest requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes, E2E tests fail because they're testing the Vercel domain instead of the deployment domain
2 participants
@Demmonius @Vadorequest