Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode switch back to light #7581

Open
wants to merge 1 commit into
base: v3.34
Choose a base branch
from
Open

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Apr 1, 2025

Summary

This PR fixes a bug where the light mode would switch back to dark when clicking on "Try it" in the split view

Changes

  • Fix user-preferences reducer

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Apr 1, 2025
@ryaplots ryaplots added this to the v3.34.1 milestone Apr 1, 2025
@ryaplots ryaplots self-assigned this Apr 1, 2025
@ryaplots ryaplots requested a review from a team as a code owner April 1, 2025 10:21
@ryaplots ryaplots requested a review from mjamescompton April 1, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant