BSO Misc Buffs #1886
BSO Misc Buffs #1886
Conversation
Signed-off-by: WazuraWasTaken <dumplingyen@gmail.com>
Signed-off-by: WazuraWasTaken <dumplingyen@gmail.com>
WalkthroughThis pull request introduces a new loadout item and configuration for the Blueshield officer role. A new energy sword option is added to both the character item group and the loadout configuration. Additionally, the job requirements for select survival loadout items have been updated to include the Blueshield officer role. The structural integrity of the YAML files is maintained with no removals of existing items. Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
no |
Signed-off-by: WazuraWasTaken <dumplingyen@gmail.com>
Signed-off-by: WazuraWasTaken <dumplingyen@gmail.com>
Signed-off-by: WazuraWasTaken <dumplingyen@gmail.com>
Signed-off-by: WazuraWasTaken <dumplingyen@gmail.com>
| - type: loadout | ||
| id: LoadoutBSOEnergySword | ||
| category: JobsCommandBlueshieldOfficer | ||
| cost: 6 | ||
| canBeHeirloom: true | ||
| guideEntry: SecurityWeapons | ||
| requirements: | ||
| - !type:CharacterItemGroupRequirement | ||
| group: LoadoutBlueshieldOfficerPrimary | ||
| - !type:CharacterJobRequirement | ||
| jobs: | ||
| - BlueshieldOfficer | ||
| - !type:CharacterAgeRequirement | ||
| min: 21 | ||
| items: | ||
| - EnergySword |
There was a problem hiding this comment.
They actually already have this available from the Security Weapons selection that they already have access to. So this part of the PR isn't strictly necessary.
There was a problem hiding this comment.
They have access to the weaker energy cutlass, this PR gives them access to the energy SWORD, which is not needed at all and way too powerful to throw into their kit
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
![coderabbitai[bot]](/https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
Resources/Prototypes/Loadouts/Generic/items.yml (1)
492-497:⚠️ Potential issueTypo Alert in Job Requirement for Survival Box
The job requirement forLoadoutItemBoxSurvivalnow includes a new entry: "- BlueshieldOfficr". Notice that the designation is missing an "o" compared to the standard "BlueshieldOfficer" used elsewhere. This typographical error could cause mismatches in job filtering and must be corrected immediately to preserve the integrity of our system.Suggested fix:
- - BlueshieldOfficr + - BlueshieldOfficer
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Resources/Prototypes/CharacterItemGroups/Jobs/Command/blueshield_officer.yml(1 hunks)Resources/Prototypes/Loadouts/Generic/items.yml(2 hunks)Resources/Prototypes/Loadouts/Jobs/Command/blueshield_officer.yml(1 hunks)
🔇 Additional comments (2)
Resources/Prototypes/Loadouts/Jobs/Command/blueshield_officer.yml (1)
70-86: Watch Your Six on the Energy Sword Loadout
The new loadoutLoadoutBSOEnergySwordis added with a cost of 6 and the proper requirements (including a minimum age of 21 and membership inLoadoutBlueshieldOfficerPrimary). However, be mindful that earlier reviews (courtesy of our vigilant Space Captains) noted that gifting an energy sword—especially one with such striking abilities—could upset the balance among our ranks. Ensure that this upgrade doesn’t let the Sol Alliance infiltrate our playbooks with overpowered armaments.Resources/Prototypes/CharacterItemGroups/Jobs/Command/blueshield_officer.yml (1)
32-33: New Entry in Officer Primary Group
The addition of theLoadoutBSOEnergySwordreference to theLoadoutBlueshieldOfficerPrimarycharacter item group looks structurally sound. This ties in nicely with the new energy sword loadout in the previous file. Just double-check that the ordering and grouping remain consistent with the other loadout items, so our officers know exactly where to report for duty.
| - Brigmedic | ||
| - BlueshieldOfficr | ||
| - !type:CharacterItemGroupRequirement |
There was a problem hiding this comment.
Correct the Job Name in Brigmedic Survival Kit Requirements
Similarly, in the LoadoutItemBoxSurvivalBrigmedic requirements, the added job entry is spelled "BlueshieldOfficr". For consistency and to ensure our officers aren’t misclassified during operations, change this to "BlueshieldOfficer".
Proposed diff:
- - BlueshieldOfficr
+ - BlueshieldOfficer📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Brigmedic | |
| - BlueshieldOfficr | |
| - !type:CharacterItemGroupRequirement | |
| - Brigmedic | |
| - BlueshieldOfficer | |
| - !type:CharacterItemGroupRequirement |
Description
Gives BSO accessed to the energy sword for 6 points as a primary weapon: Okay so my thought process for this is that, BSO currently has these options the; BRDI is all around good although expensive, the energy shield that might be replaced by the ones from goob, the Chester... after the .45 ammo changes its never going to be used(like everyone was using it in the first place to begin with) and last and my favorite the energy shotgun which after the it received is now in a fantastic place. Now, why the energy sword? Simple it looks cool and has a niche, which is; tanking and reflecting shots back at enemies and also being a great melee weapon. Have I mention it just looks sick and the intimidation factor of it!
Alright aside from that I think it fits the role of the BSO quite well, since your suppose to run in and be a shield for command. Granted the shield from goob would pretty much fill this role, but can it light a cigarette?
Allow BSO to use Corpsman's survival box: They are basically the upgraded and more well armed version of the corpsman, but for command. I find it strange, that they use the basic survival kit instead of this one.
Media
Changelog
🆑