SWPROT-8953: Disable Werror on UnifySDK dep release #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
requested review from
silabs-aydogane,
Thomasdjb,
agarwal57 and
silabs-JulienT
rzr
added a commit
that referenced
this pull request
Feb 10, 2025
As explain in patch it is good to use Werror in devel or ci branch
not in releases (tags).
This change is not yet applied upstream,
to support more compilers, issue has been reported on OSX using
```
➜ ~ cc --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
➜ ~ c++ --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
```
I would be nice to fix this in the upstream too:
.../unifysdk-src/components/uic_main/src/uic_init.c:77:21: \
error: passing arguments to 'sl_log_read_config' \
without a prototype is deprecated in all versions of C \
and is not supported in C2x \
[-Werror,-Wdeprecated-non-prototype]
sl_log_read_config(NULL);
Origin: #25
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr
added a commit
that referenced
this pull request
Feb 10, 2025
As explain in patch it is good to use Werror in devel or ci branch
not in releases (tags).
This change is not yet applied upstream,
to support more compilers, issue has been reported on OSX using
```
➜ ~ cc --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
➜ ~ c++ --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
```
I would be nice to fix this in the upstream too:
.../unifysdk-src/components/uic_main/src/uic_init.c:77:21: \
error: passing arguments to 'sl_log_read_config' \
without a prototype is deprecated in all versions of C \
and is not supported in C2x \
[-Werror,-Wdeprecated-non-prototype]
sl_log_read_config(NULL);
Origin: #25
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
|
#11 96.51 fatal: unable to auto-detect email address (got 'root@buildkitsandbox.(none)') |
As explain in patch it is good to use Werror in devel or ci branch
not in releases (tags).
This change is not yet applied upstream,
to support more compilers, issue has been reported on OSX using
```
➜ ~ cc --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
➜ ~ c++ --version
Apple clang version 15.0.0 (clang-1500.3.9.4)
Target: x86_64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
```
I would be nice to fix this in the upstream too:
.../unifysdk-src/components/uic_main/src/uic_init.c:77:21: \
error: passing arguments to 'sl_log_read_config' \
without a prototype is deprecated in all versions of C \
and is not supported in C2x \
[-Werror,-Wdeprecated-non-prototype]
sl_log_read_config(NULL);
Origin: #25
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
silabs-aydogane
approved these changes
Feb 11, 2025
1 task
rzr
added a commit
to rzr/UnifySDK
that referenced
this pull request
Feb 13, 2025
Threating warning as error is a good practice durring development phase, for release it's ok to relax this to support more (future) compilers and then provide best effort support on non supported environements. For instance we might allow users to support stable version of gcc (gcc-13 currently which is not yet enabled in our CI) Of course this change should be reverted on development branch, ASAP, and introduced again for next releases. Ideally it should be near to release tags. For the record it was useful to support MacOS: ``` ➜ ~ cc --version Apple clang version 15.0.0 (clang-1500.3.9.4) Target: x86_64-apple-darwin23.4.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin ➜ ~ c++ --version Apple clang version 15.0.0 (clang-1500.3.9.4) Target: x86_64-apple-darwin23.4.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin ``` Origin: uic/pull-requests/2704/overview Relate-to: uic/pull-requests/2705/overview?commentId=796680 Relate-to: /x/FND4Dg#BrainstormItems-Identifystandardsbreakage Forwarded: uic/pull-requests/2704/overview Forwarded: SiliconLabsSoftware/z-wave-protocol-controller#25 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explain in patch it is good to use Werror in devel or ci branch not in releases (tags).
This change is not yet applied upstream,
to support more compilers, issue has been reported on OSX using
I would be nice to fix this in the upstream too:
Change
Checklist