Skip to content

GH-39: Prioritize command classes for interview #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nkljajic
Copy link
Collaborator

@nkljajic nkljajic commented Apr 7, 2024

First time we use COMMAND_CLASS_VERSION, query its own version supported.

Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others. UAM rules can match unique device model, so we could override supported command class version attributes for matching device model.

nkljajic added a commit to nkljajic/UnifySDK that referenced this pull request Apr 7, 2024
First time we use COMMAND_CLASS_VERSION, query its own version supported.

Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others.
UAM rules can match unique device model, so we could override
supported command class version attributes for matching device model.

Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
@nkljajic nkljajic force-pushed the bugfix/GH-39-fix-prioritize-CC-for-interview branch from 714d5c6 to 15ef046 Compare April 7, 2024 09:22
Copy link
Collaborator

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I will test it until approve

Feel free to also pick this change to trigger tests:

#42

nkljajic added a commit to nkljajic/UnifySDK that referenced this pull request Apr 24, 2024
First time we use COMMAND_CLASS_VERSION, query its own version supported.

Prioritize COMMAND_CLASS_MANUFACTURER_SPECIFIC before others.
UAM rules can match unique device model, so we could override
supported command class version attributes for matching device model.

Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
@nkljajic nkljajic force-pushed the bugfix/GH-39-fix-prioritize-CC-for-interview branch from 33b7883 to 6f120a1 Compare April 24, 2024 10:02
@nkljajic nkljajic marked this pull request as draft June 14, 2024 05:27
@nkljajic nkljajic marked this pull request as ready for review June 14, 2024 05:27
@rzr
Copy link
Collaborator

rzr commented Jul 17, 2024

Integration in process:

Origin: https://github.com/SiliconLabs/UnifySDK/pull/39
Bug-SiliconLabs: UIC-3082
Forwarded-SiliconLabs: task/UIC-3082/phcoval/GH-39/develop#pull-requests/2789

@rzr
Copy link
Collaborator

rzr commented Jul 18, 2024

Origin-SiliconLabs: ver_1.6.0-unstable-57-g8a3e68cc90

@rzr rzr merged commit c5cf19c into SiliconLabs:main Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants