Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify proc_creation_win_ping_hex_ip.yml to look for hexidemical strings using regex #5251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vasquja
Copy link

@vasquja vasquja commented Apr 2, 2025

Summary of the Pull Request

I found false positives in my org's environment when pinging by hostname where the string '0x' is included in the hostname. For example, this rule would identify the command 'ping c0xk2jhf79' when this is a host name, not a hex IP address. Using regex can look for string starting with 0x and containing 8 characters after, representing an IPv4 address and thereby reducing false-positive detections.

Changelog

Example Log Event

AccountName: SYSTEM
AccountType: User
Category: Process Create (rule: ProcessCreate)
Channel: Microsoft-Windows-Sysmon/Operational
CommandLine: ping c0xk2jhf79
Company: Microsoft Corporation
CurrentDirectory: F:
Description: TCP/IP Ping Command
Domain: NT AUTHORITY
EventCreated: 2025-04-02 15:00:35 Eastern Daylight Time
EventID: 1
EventReceivedTime: 2025-04-02T15:00:37.461571-04:00

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

vasquja added 2 commits April 2, 2025 15:04
Using rex to identify hex as opposed to a hostname with '0x' in the name. Also excluding the string 'exceptions' from error messages which contain 0x in the error message.
@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels Apr 2, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @vasquja 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant