Skip to content

adding page factory support for python selenium community #7214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ToxicEnvelope
Copy link

@ToxicEnvelope ToxicEnvelope commented May 16, 2019

@ToxicEnvelope
Copy link
Author

added tests for page factory poc on pom

@p0deje p0deje added the C-py Python Bindings label May 17, 2019
@lmtierney
Copy link
Member

IMO this belongs in a support library and not in the selenium library itself.

@ToxicEnvelope
Copy link
Author

ToxicEnvelope commented May 17, 2019

@lmtierney,
how can we add such pattern into selenium?
the community actually looking for this pattern.
or How can I take part in the buildup?

@AutomatedTester
Copy link
Member

Personally I don't see why this change is needed in the first place, python allows you do these things already without having the bloat added to bindings. Also... what is with all the bad spending of factory?

@lmtierney
Copy link
Member

@lmtierney ,
Okay :)
To which package should i move it then?
Thx,
Yahav N.

You could create your own OSS package.

@ToxicEnvelope
Copy link
Author

@AutomatedTester,
Try to use my pattern , and try to compare it to others patterns when you
create new POMs I guarnetee not such thing as any exception regarding StaleElement.
plus,
It's readable and return multiple cache functions as objects in a flat manner when using it the find_by pattern.
You will never again will need to try to identify the reference of WebElement object

@isaulv
Copy link
Contributor

isaulv commented Jul 28, 2019

I agree with Lucas and Dave that the API is a bit difficult, that you should create your own project.
Also caching elements doesn't make sense to me since Javascript can change any element right after you retrieve that element.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AutomatedTester
Copy link
Member

Closing as this should be it's own package on top of Selenium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-py Python Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants