Skip to content

[dotnet] [bidi] Unignore GetClientWindows test for chromium #15534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Mar 29, 2025

User description

Motivation and Context

CanGetClientWindows is now supported by chromium.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Tests


Description

  • Unignored the CanGetClientWindows test for Chromium.

  • Removed browser ignore annotations for Chrome and Edge.

  • Ensured compatibility of the test with Chromium's BiDi support.


Changes walkthrough 📝

Relevant files
Tests
BrowserTest.cs
Unignored `CanGetClientWindows` test for Chromium               

dotnet/test/common/BiDi/Browser/BrowserTest.cs

  • Removed IgnoreBrowser annotations for Chrome and Edge.
  • Enabled the CanGetClientWindows test for Chromium.
  • +0/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member Author

    CI is failing unrelated to this PR, just merging.

    @nvborisenko nvborisenko merged commit 1318f59 into SeleniumHQ:trunk Mar 29, 2025
    9 of 10 checks passed
    @nvborisenko nvborisenko deleted the bidi-get-client-window branch March 29, 2025 16:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant