Add support to webhook for Gogs & Gitea services #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #288 |
|
👍 I'll get it merged this evening and tag a new release also. One minor thing, would you be able to update https://github.com/REBELinBLUE/deployer/blob/master/resources/views/projects/dialogs/webhook.blade.php#L46 to list Gogs/Gitea as well |
REBELinBLUE
changed the title
REBELinBLUE
added a commit
that referenced
this pull request
Nov 24, 2016
* master: Updated CHANGELOG [IMPROVEMENT] Adding Webhook handler for Gogs/Gitea (#289) Cleanup Checking that message has an event property before using it Fix file permissions Updated yarn.lock Added yarn lock Fixes #278 - Changes how the DB is checked in migrations and adds a migration to attempt to re-run missed migrations
axeloz
commented
Nov 24, 2016
| class Gogs extends Webhook | ||
| { | ||
| /** | ||
| * Determines whether the request was from Github. |
There was a problem hiding this comment.
Pushed too fast earlier, let mentions of Github in comments, dirty work, sorry
axeloz
commented
Nov 24, 2016
| namespace REBELinBLUE\Deployer\Http\Webhooks; | ||
|
|
||
| /** | ||
| * Class to handle integration with Github webhooks. |
There was a problem hiding this comment.
Pushed too fast earlier, let mentions of Github in comments, dirty work, sorry
|
Oops, and I didn't notice that either 🙊
Stephen Ball
stephen@rebelinblue.com
… On 24 Nov 2016, at 18:44, axeloz ***@***.***> wrote:
@axeloz commented on this pull request.
In app/Http/Webhooks/Gogs.php:
> @@ -0,0 +1,51 @@
+<?php
+
+namespace REBELinBLUE\Deployer\Http\Webhooks;
+
+/**
+ * Class to handle integration with Github webhooks.
Pushed too fast earlier, let mentions of Github in comments, dirty work, sorry
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Description of change
Adding a Gogs/Gitea handler for Webhook.
Please provide a description of the change here.
Github handler doesn't work for Gogs as the "head_commit" doesn't exist in the Payload.