Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Context Options for https, Restore Disabled Tests #4276

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Additional Context Options for https, Restore Disabled Tests #4276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3078ea9
Additional Context Options for https, Restore Disabled Tests
oleibman Dec 12, 2024
6247643
Add Context for http Requests
oleibman Dec 13, 2024
cc86557
Remove Connection: keep-alive
oleibman Dec 13, 2024
92292e5
Simplify Accept Header
oleibman Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove Connection: keep-alive 
Unacceptable performance.
  • Loading branch information
@oleibman
oleibman committed Dec 13, 2024
commit cc86557b7718e2da390193b03ee266655415d57c
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ and this project adheres to [Semantic Versioning](https://semver.org).

### Deprecated

- Nothing yet.
- Drawing::setIsUrl is unneeded. The property is set when setPath determines whether path is a url.

### Fixed

- Nothing yet.
- More context options may be needed for http(s) image. [Php issue 17121](https://github.com/php/php-src/issues/17121) [PR #4276](https://github.com/PHPOffice/PhpSpreadsheet/pull/4276)

## 2024-12-08 - 3.6.0

Expand Down
2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Worksheet/Drawing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public function setPath(string $path, bool $verifyFile = true, ?ZipArchive $zip
'http' => [
'user_agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36',
'header' => [
'Connection: keep-alive',
//'Connection: keep-alive', // unacceptable performance
// accept header used by chrome without image/webp
'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7',
],
Expand Down
Loading