-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a VM template using VM save creates a template with duplicate disks #6831
Comments
I can't reproduce it, tested with master, 6.10.2, 6.4.7 and 6.4.0. I looked at the code and can't see how this can happen. I can confirm only extra elements for volatile disks. @atodorov-storpool If you still can reproduce it, please paste here output of |
|
This is on 6.10.2 - fresh install:
|
@atodorov-storpool Can you please do me a favor and try to replace file If you want to check changes, here is the commit This update specifically addresses extra attributes for volatile disks, but it might have the side effect of fixing the duplication issue as well. To help me narrow things down, could you also share the versions of the |
Hi @paczerny, I missed clarifying that the tests are on RHEL-based distros — Centos7(yeah, I still have customers who haven't upgraded/migrated, so I need testing) with opennebula-6.4-ee and Alma8 with opennebula-6.10-ee. Today, I tested on a fresh Ubuntu24.04 install - the issue does not manifest there.
Tested the new version on the Alma8 test deployment - it is fixing the issue. The gems installed by ONE are Hope this helps. Best Regards, |
Great, thank you. The fix will be included in 6.10.3 release |
* Add comment to template_like_str method (cherry picked from commit a788592)
* Add comment to template_like_str method
Description
When a VM Template is created using VM save of a VM with multiple non-persistent disks the resulting template has listed both the newly created image clones of the running VM disks and the "master" disk images of the current VM disks (no matter on instantiate or hot attached)
To Reproduce
Create a VM with several non-persistent VM disks (and a volatile disk just for a flavour)
Power-off the VM
Use
onevm save $VM_ID name_of_the_new_template
or sunstone (not checking the option to make the image clones persistent)Please take a look at the generated VM Template. There are more disks than on the VM that is saved.
If a VM is instantiated from this template, there will be two disks in place of each original non-persistent disk.
Expected behavior
A VM Template with disks based on defined clones only.
Details
Additional context
The volatile disk definition is not "doubled" but the provided definition elements are more than needed for a VM Tempalte (IMO).
Second observation - adding a new volatile disk to such a template reduces (sanitizes?) the elements of the disks defined in the template, but the "doubled" no-persistent disks are still there.
Progress Status
The text was updated successfully, but these errors were encountered: