[Feature] Intrinio Delayed Options #6505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeleeramone
added
enhancement
IgorWounds
reviewed
Jun 16, 2024
| ) | ||
| contract_symbol: str = Field(description="Contract symbol for the option.") | ||
| eod_date: Optional[dateType] = Field( | ||
| default=None, description="Date for which the options chains are returned." | ||
| ) | ||
| expiration: dateType = Field(description="Expiration date of the contract.") | ||
| dte: Optional[int] = Field( |
There was a problem hiding this comment.
I'd vote for a more verbose name on the standard model. I'm fine with dte but we did want more verbosity.
IgorWounds
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
What?:
Small renovation to standard model, but no breaking changes.
With no date, Intrinio provider will fetch the current data.
Adds additional params to the Intrinio model.
Adds new path:
options.snapshots.Impact:
obb.derivatives.options.snapshots(provider="intrinio")will return a large amount of data from bulk download endpoint.Testing Done: