Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options Menu Symbol Label Fixes #3735

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

simmonsj330
Copy link
Contributor

Description

Adds labels to options menu tables. No github issue number, but there is a jira ticket (PLAT-1510).

Info
Screenshot 2022-12-08 at 12 36 24 PM

Chains
Screenshot 2022-12-08 at 12 37 02 PM

Greeks
Screenshot 2022-12-08 at 12 37 23 PM

Parity
Screenshot 2022-12-08 at 12 37 43 PM

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@simmonsj330 simmonsj330 added the enhancement Enhancement label Dec 8, 2022
@simmonsj330 simmonsj330 requested a review from jmaslek December 8, 2022 17:38
@simmonsj330 simmonsj330 self-assigned this Dec 8, 2022
@reviewpad reviewpad bot added feat XS and removed feat XS labels Dec 8, 2022
@simmonsj330
Copy link
Contributor Author

Deleted test txt files by accident, will fix

@reviewpad reviewpad bot added feat XS and removed feat XS labels Dec 8, 2022
@deeleeramone
Copy link
Contributor

Nice, @simmonsj330!

Can this be applied to bot as well? The images that are tables don't have identifying labels, or that same snazzy branding.

image

@simmonsj330
Copy link
Contributor Author

Nice, @simmonsj330!

Can this be applied to bot as well? The images that are tables don't have identifying labels, or that same snazzy branding.

@andrewkenreich

@andrewkenreich
Copy link
Contributor

I'm confused what you are asking for here on bot side? You mean the words spelled out?

@reviewpad reviewpad bot added feat XS and removed feat XS labels Dec 9, 2022
@reviewpad reviewpad bot added feat XS and removed feat XS labels Dec 9, 2022
@deeleeramone
Copy link
Contributor

I'm confused what you are asking for here on bot side? You mean the words spelled out?

I mean to have those details as part of the image because, when you view the table by clicking on it, there is no title or branding.

@jmaslek jmaslek merged commit fb667ce into OpenBB-finance:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants