Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Reviewpad workflows #3731

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Feat: Add Reviewpad workflows #3731

merged 2 commits into from
Dec 13, 2022

Conversation

ferreiratiago
Copy link
Contributor

Description

This pull request introduces changes to the Reviewpad configuration, mainly:

  • The new workflow sanity, which validates that:
    • When a pull request only changes .py files and has more than 1000 changed lines, it fails the Reviewpad check and asks the developer to split the PR into multiple PRs.
    • When it contains a binary file, it fails the Reviewpad check and asks the developer to remove the binaries from the PR.
  • The new workflow dependencies, which validates that:
    • When changing any of the files pyproject.tom or poetry.lock and missing the changes to requirements, it requests for changes to update both requirements.txt and requirements-full.txt.

It also fixes the issue of removing the size label and adding the size label on every Reviewpad run (an issue introduced on #3710).

How has this been tested?

The configuration was tested using Reviewpad playground.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@jmaslek jmaslek requested review from luqmanbello and piiq December 8, 2022 15:20
@reviewpad
Copy link

reviewpad bot commented Dec 8, 2022

Reviewpad Report (Reviewpad ran in dry-run mode because configuration has changed)

📜 Executed actions

$removeLabels(["feat S", "feat M", "feat L", "feat XL"])
$addLabel("feat XS")

@jmaslek jmaslek added the enhancement Enhancement label Dec 13, 2022
@jmaslek jmaslek merged commit 5f47ca2 into OpenBB-finance:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants