-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pinned apps to support wildcard globs #898
Conversation
https://github.com/OSC/ondemand/pull/898/files#diff-60fef4a9a6a3bd5d06e005f9d166e5fb2522e5a740569fd3402cbe1c0e322213R4-R16 is duplicate of ondemand/apps/dashboard/app/controllers/application_controller.rb Lines 29 to 39 in e25637a
To remove this duplication I would instead do this:
|
Router#pinned_apps now supports glob style wildcards like sys/* and sys/bc_desktop/* (usr/ and dev/ included). This also adds public Router#apps methods to be possibly useful in the future. This also adds a OodApp#has_sub_apps? api to determine if an app in fact has valid sub apps for showing the subapp in the pinned apps menus.
refactor pinned_apps to accept the tokens and apps as input and compute pinned apps. This puts app logic/member variables in the controllers instead of in Router
1e36d8f
to
b60b10e
Compare
Done in 5059010. I had to rebase off of the current master because I removed the helper |
Router#pinned_apps now supports glob style wildcards like sys/* and
sys/bc_desktop/* (usr/ and dev/ included). This also adds public Router#apps
methods to be possibly useful in the future.
This also adds a OodApp#has_sub_apps? api to determine if an app
in fact has valid sub apps for showing the subapp in the pinned
apps menus.
I can comment in the tickets where behaviour is defined more specifically, but basically here are a few common use cases for this: