Added support to edit saved settings from the details view #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some screenshots: 
|
abujeda
force-pushed
the
saved_settings_management_edit
branch
2 times, most recently
from
2241a07 to
40255a6
Compare
|
I'm a bit busy this week - I may not get to this so quickly. |
abujeda
force-pushed
the
saved_settings_management_edit
branch
from
40255a6 to
903032d
Compare
|
rebasing to resolve conflicts |
johrstrom
reviewed
Apr 23, 2024
apps/dashboard/config/locales/en.yml
Outdated
| @@ -261,6 +262,9 @@ en: | |||
| missing_settings: "Selected saved settings not found." | |||
| launch_label: "Launch" | |||
| launch_title: "Launch %{app_title} with %{settings_name} parameters" | |||
| edit_label: "Edit" | |||
There was a problem hiding this comment.
This is duplicate of just edit later in this file. I know this is in the batch_connect portion, but I'd like to reuse those common simple words if we can.
johrstrom
reviewed
Apr 23, 2024
| redirect_to batch_connect_setting_path(token: @app.token, id: template_name), | ||
| notice: t('dashboard.bc_saved_settings.saved_message', settings_name: template_name) | ||
| end | ||
| format.json { head :no_content } |
There was a problem hiding this comment.
Does the javascript use this json API? I don't see it if so. If nobody actually uses it, I'd rather just remove it entirely.
There was a problem hiding this comment.
No, the javascript does not use this API. I added the JSON response because the create method had one.
I have removed.
johrstrom
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to edit the saved settings from the saved settings details page.
As well, added a
save and closefeature to allow the user to save the saved settings from the BatchConnect context page without having to launch an application.Other improvements: