Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundler execution #318

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Fix bundler execution #318

merged 3 commits into from
Nov 28, 2019

Conversation

treydock
Copy link
Contributor

Maybe fix for #316

FWIW I made this change on webdev02 and it solved the problem of launching My Jobs with a ~/.bundle/config present.

@treydock
Copy link
Contributor Author

I only made first commit change on webdev02, others need testing or pre-release to see if fixes other issues from #316

@johrstrom
Copy link
Contributor

I tested this on dev and it worked for me.

@ericfranz
Copy link
Contributor

ENV['BUNDLE_USER_CONFIG'] = '/dev/null' if Rails.env.production?

Why scope this to if Rails.env.production??

@treydock
Copy link
Contributor Author

I for some reason thought dev apps don't run in production rails enviornment but they must as they run under passenger.

@treydock
Copy link
Contributor Author

Updated PR to remove environment check

@ericfranz
Copy link
Contributor

It’s a misnomer. The name is “setup-production” but it’s actually just “per user setup”. So if the dashboard is running in “developer mode” it might still display a link to an app deployed that I want to launch and verify the dashboard does the per user setup for that app. That per user setup should happen without conflicts from BUNDLE_USER_CONFIG regardless of the mode the dashboard is running as.

@ericfranz ericfranz merged commit 3c4c22c into master Nov 28, 2019
@ericfranz ericfranz deleted the fix-bundler branch November 28, 2019 15:41
@johrstrom johrstrom added this to the OOD1.7 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants