Validate Rclone remotes in initializer #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validates by trying to query in parallel with a timeout of 6s. Disabled by default, enable by setting OOD_REMOTE_FILES_VALIDATION.
johrstrom
reviewed
Aug 9, 2023
johrstrom
reviewed
Aug 9, 2023
johrstrom
reviewed
Aug 11, 2023
| @@ -5,6 +5,7 @@ bc_simple_auto_accounts: true | |||
| per_cluster_dataroot: true | |||
| file_navigator: true | |||
| remote_files_enabled: true | |||
| remote_validation: true | |||
There was a problem hiding this comment.
OK - let's keep the option but can we rename it to remote_files_validation?
robinkar
force-pushed
the
validate-rclone-remotes
branch
from
0e18c11 to
6e53c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration option that can be enabled to add only valid and accessible Rclone remotes to favorite paths.
The remotes are validates by trying to list the directories in the remote in parallel with a timeout of 6s (this is mostly chosen due to strange Rclone timeout behaviour). The feature is disabled by default, enable by setting
OOD_REMOTE_VALIDATIONto true. This might not be the best name for the configuration option, but was the shortest reasonable name I could think of (maybeOOD_RCLONE_REMOTE_VALIDATIONwould be better?).