Fix K8 username prefix to match ood_core behavior #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanted to keep some similarity between cluster YAML and hook.env changes so both can be |
|
I like the check, but actually I'd like to change it in ood_core too. Do you want both, change it here now then change it in ood_core then change it again? (that'd be a 2.1 thing). |
|
What does ood_core change look like? Is it removing the assumed hyphen? |
|
Yea to keep the same look & feel of the namespace prefix (which expects the - to be in the config). |
|
I vote we merge this now, and then we can circle back and do both ood_core and undo this in same go. That way I don't have to put bandaids into Puppet configs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.