Skip to content

Misleading warning #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emartynov opened this issue Feb 16, 2022 · 6 comments · Fixed by #50
Closed

Misleading warning #45

emartynov opened this issue Feb 16, 2022 · 6 comments · Fixed by #50
Labels
enhancement New feature or request
Milestone
Release 1.5

Comments

@emartynov
Copy link

Super thank you for the work under the plugin.

We have next project structure:

root 
   features 
      registration
      fit
      ...
  core
     network
     ...
  app

We are getting warning that projects features and core are not supported. However, they are not projects but just container folders.
@Rolf-Smit
Copy link
Contributor

@emartynov this is something I will fix in the next release.

@Rolf-Smit
Copy link
Contributor

In the next release instead of a warning this will likely become something like this:

Notice: skipping module x because Android Gradle Plugin was not detected

Which is also not going to be logged on the WARNING level but on the INFO level.

@Rolf-Smit Rolf-Smit added the enhancement New feature or request label Mar 8, 2022
@Rolf-Smit Rolf-Smit added this to the Release 1.5 milestone Mar 8, 2022
@emartynov
Copy link
Author

Rolf, it is still misleading since they are not modules

@Rolf-Smit
Copy link
Contributor

Rolf-Smit commented Mar 8, 2022 •
edited
Loading

From a Gradle perspective they are actually seen as modules (that is also why the warning is triggered for those in the first place), so it might be hard to differentiate.

But I will see what I can do.

Rolf-Smit added a commit that referenced this issue May 12, 2022
@Rolf-Smit
Fix: Don't log "skipping module" message for Gradle (sub)projects wit…
4b6452f 
…hout a build.gradle file

Fixes #45
@Rolf-Smit Rolf-Smit mentioned this issue May 12, 2022
Merged
Rolf-Smit added a commit that referenced this issue May 12, 2022
@Rolf-Smit
Fix: Don't log "skipping module" message for Gradle (sub)projects wit…
8c7de7a 
…hout a build.gradle file (#50)

Fixes #45
@Rolf-Smit
Copy link
Contributor

Fixed in #50, will be released in version 1.5.

@Rolf-Smit Rolf-Smit mentioned this issue May 12, 2022
Merged
Rolf-Smit added a commit that referenced this issue May 12, 2022
@Rolf-Smit
Release 1.5.0 (#53)
0b28266 
Google finally released a stable version of the Android Gradle Plugin 7.2 that fixes #36, this means we can finally create a new stable release for this plugin:

- Most of the plugin has been rewritten to only make use of public Android Gradle Plugin API's, functionally this should not change anything compared to previous releases.
- Adds a minimum required Android Gradle Plugin version check, using an Android Gradle Plugin version that is too old will result in a Gradle build error.
- No longer logs warning messages for (sub)projects (modules) that do not use the Android Gradle Plugin. Instead this is now an info message. This info message will only show for (sub)projects that have a build.gradle file (see #45).
- No longer logs warning messages asking to apply the JaCoCo plugin yourself, instead the plugin takes care of this now.
- Potentially fixes #42, since JaCoCo will now always be applied by the plugin at the root project.
@Rolf-Smit
Copy link
Contributor

I've added a check which checks if a Gradle sub(project) is an empty container for other (sub)projects, like in your case. If that is the case it will not log a message. "empty container" means in this case that there is no build.gradle file in that folder.

This is released with version 1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1.5
2 participants
@emartynov @Rolf-Smit