This repository was archived by the owner on Mar 13, 2023. It is now read-only.
feat 💥: delay non-raw listeners until client ready #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasary
suggested changes
Sep 9, 2022
silasary
approved these changes
Sep 9, 2022
7 tasks
LordOfPolls
added a commit
that referenced
this pull request
Sep 14, 2022
* feat 💥: delay non-raw listeners until client ready * fix: dont delay error events
LordOfPolls
added a commit
that referenced
this pull request
Sep 14, 2022
LordOfPolls
added a commit
that referenced
this pull request
Sep 17, 2022
* feat 💥: delay non-raw listeners until client ready (#635) * feat 💥: delay non-raw listeners until client ready * fix: dont delay error events * refactor💥: Improved ux for select menus * docs: update select reference remnant in guide
LordOfPolls
added a commit
that referenced
this pull request
Sep 20, 2022
* feat 💥: delay non-raw listeners until client ready (#635) * feat 💥: delay non-raw listeners until client ready * fix: dont delay error events * refactor 💥: Update and organise event bases (#636) * feat: allow listeners to be deleted if they are marked as overwritable * feat!: convert error and completion handlers to events, rename the completion events and add/rename modal events * refactor: rename `delete_if_overwritten` to `delete_if_overridden` Co-authored-by: LordOfPolls <dev@lordofpolls.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
Delays the execution of listeners until the client is in a ready state. By default, all non-raw listeners are delayed.
Changes
delay_until_readyattribute to listenersChecklist
Python 3.10.x