This repository was archived by the owner on Mar 13, 2023. It is now read-only.
fix: Adjust typehinting for project packaging #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
#174 was wrongly thought to make sure
.pyi
files were being included when installingDis-Snek
from PIP. To an extent, it did, as usingpip install .
in theDis-Snek
project itself would work but installing it from a wheel or using PyPI would not include these files.This PR fixes that, making sure those files are included while building the package.
EDIT: as per request,
py.typed
has also been fixed.Changes
package_data
fromsetup.py
and useinclude_package_data
instead.setup.py
ignored it.MANIFEST.in
forinclude_package_data
and make it include.pyi
files (and some other basic files).py.typed
to the correct spot and add it toMANIFEST.in
.Checklist
Python 3.10.x
Additional Note
EDIT: The below note has been adjusted for in this PR now, as per request.
While doing this PR, I found out we technically don't have a
py.typed
, which is why it's not included inMANIFEST.in
. That probably needs to be added in a separate PR, though I can add it here if needed.