Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Search in diff view #626

Open
jgarte opened this issue Mar 11, 2022 · 2 comments
Open

Feature Request: Search in diff view #626

jgarte opened this issue Mar 11, 2022 · 2 comments

Comments

@jgarte
Copy link
Contributor

jgarte commented Mar 11, 2022

Hi,

Is there a way to search?

/ doesn't work for example

@jgarte jgarte changed the title Feature Request: Search through patches Feature Request: Search Mar 12, 2022
@MitMaro
Copy link
Owner

MitMaro commented Mar 26, 2022

Good idea! There's already #237, but I think being able to search a patch also makes sense.

I've done some initial work on #237 over the past year, and it should be possible to extend the search functionality to include this as well:

IMAGE ALT TEXT

@MitMaro MitMaro moved this to Triage in GIRT Project Mar 26, 2022
@MitMaro MitMaro moved this from Triage to Backlog in GIRT Project Mar 26, 2022
@MitMaro MitMaro changed the title Feature Request: Search Feature Request: Search in diff view Nov 18, 2022
@MitMaro
Copy link
Owner

MitMaro commented Nov 18, 2022

I've added searching to the list view in #797 , but I would like to add search to the patch/diff view as well.

Right now, the "linear" search I used in the list view would be too slow for diffs, at least having the search in the main thread. I've spent the past year adding support for threading to the project, and hope to eventually add search that runs in a background thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants