Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search functionality and hotkey #237

Closed
glensc opened this issue Apr 22, 2020 · 2 comments
Closed

Add search functionality and hotkey #237

glensc opened this issue Apr 22, 2020 · 2 comments
Assignees

Comments

@glensc
Copy link

glensc commented Apr 22, 2020

Coming from vim, I really missing search functionality:

  • search for commit id
  • search for commit message

I would expect this to be activated like in vim: / hotkey and behave like hlsearch enabled

If I'm reading screenful of commits (don't ask why), I find my fingers type faster to find commit I'm interested in by search than visual grep (👀) for the commit

@MitMaro
Copy link
Owner

MitMaro commented Apr 23, 2020

I really like this idea and I wish I had thought of it myself!

@MitMaro MitMaro moved this from Triage to In Progress in GIRT Project Mar 26, 2022
@MitMaro MitMaro moved this to Triage in GIRT Project Mar 26, 2022
@MitMaro MitMaro self-assigned this Mar 26, 2022
@MitMaro
Copy link
Owner

MitMaro commented Nov 18, 2022

Search from within the list view was added in #797. I haven't added screenshots to the README yet, but in development, / starts a search, Enter "finishes" the search, then n and N move between search results.

I tried to keep the default key-bindings and behaviour similar to vim.

I've been working on this for so long, that I forgot there was an issue open for it. 😅

I'm hoping to do a release early in the new year, that will contain this functionality.

@MitMaro MitMaro closed this as completed Nov 18, 2022
Repository owner moved this from In Progress to Complete in GIRT Project Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

No branches or pull requests

2 participants