Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue of app not throwing an error when Flyway migration fails #3034

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonathanlbt1
Copy link

Problem

This pull request includes changes to improve error handling and code readability in the MarquezApp class. The most important changes include adding a custom exception, modifying the run method to throw the new exception, and improving code formatting whenever Flyway fails a migration.

Closes: #3033

Solution

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the api API layer changes label Mar 8, 2025
Copy link

boring-cyborg bot commented Mar 8, 2025

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Copy link

netlify bot commented Mar 8, 2025

Deploy Preview for peppy-sprite-186812 failed.

Name Link
🔨 Latest commit 2358703
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/67ce2502fff3f9000958a38b

Signed-off-by: Jonathan Moraes <jonathan.pinto@cs.unicid.edu.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flyway failing message
1 participant