Fixing issue of app not throwing an error when Flyway migration fails #3034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This pull request includes changes to improve error handling and code readability in the
MarquezApp
class. The most important changes include adding a custom exception, modifying therun
method to throw the new exception, and improving code formatting whenever Flyway fails a migration.Closes: #3033
Solution
api/src/main/java/marquez/MarquezApp.java
: Added theDbException
import and modified therun
method to throwDbException
on database migration errors instead of logging and terminating the application. [1] [2] [3]One-line summary:
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)