Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps on proposing changes to Marquez #2065

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Aug 10, 2022

Problem

Marquez does not currently outline steps for proposing changes or a template outlining a design doc for a proposal.

Solution

Add steps on how to submit a proposal for review wand a design doc tempalte.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2065 (bd61022) into main (1330831) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head bd61022 differs from pull request most recent head 6a95c60. Consider uploading reports for the commit 6a95c60 to get more accurate results

@@             Coverage Diff              @@
##               main    #2065      +/-   ##
============================================
- Coverage     78.79%   78.79%   -0.01%     
  Complexity     1011     1011              
============================================
  Files           200      200              
  Lines          5574     5573       -1     
  Branches        422      422              
============================================
- Hits           4392     4391       -1     
  Misses          730      730              
  Partials        452      452              
Impacted Files Coverage Δ
api/src/main/java/marquez/db/FlywayFactory.java 96.96% <0.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc marked this pull request as ready for review August 10, 2022 03:33
@wslulciuc wslulciuc added the review Ready for review label Aug 10, 2022
Copy link
Contributor

@mobuchowski mobuchowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wslulciuc wslulciuc removed the review Ready for review label Aug 10, 2022
@wslulciuc wslulciuc enabled auto-merge (squash) August 10, 2022 17:06
@wslulciuc wslulciuc merged commit dbdea1a into main Aug 10, 2022
@wslulciuc wslulciuc deleted the feature/template-for-proposals branch August 10, 2022 17:11
jonathanpmoraes pushed a commit to nubank/NuMarquez that referenced this pull request Feb 6, 2025
* Add steps for proposal review

Signed-off-by: wslulciuc <willy@datakin.com>

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants