Add @FlywayTarget annotation to migration tests to control flyway upg… #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2035 +/- ##
============================================
- Coverage 78.92% 78.83% -0.09%
+ Complexity 1018 1015 -3
============================================
Files 199 199
Lines 5557 5557
Branches 421 421
============================================
- Hits 4386 4381 -5
- Misses 724 726 +2
- Partials 447 450 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
wslulciuc
reviewed
Jul 15, 2022
api/src/main/java/marquez/db/migrations/V44_2__BackfillAirflowParentRuns.java
Show resolved
Hide resolved
wslulciuc
reviewed
Jul 15, 2022
api/src/test/java/marquez/db/migrations/V44_2__BackfillAirflowParentRunsTest.java
Show resolved
Hide resolved
api/src/test/java/marquez/db/migrations/V44_3_BackfillJobsWithParentsTest.java
Outdated
Show resolved
Hide resolved
…rades Updated backfill tests to fix flyway migration version and update to stop relying on sql in DAOs since they change with future migrations Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
collado-mike
force-pushed
the
flyway_fixed_migration
branch
from
977a203 to
2eb2bf1
Compare
jonathanpmoraes
pushed a commit
to nubank/NuMarquez
that referenced
this pull request
Feb 6, 2025
MarquezProject#2035) * Add @FlywayTarget annotation to migration tests to control flyway upgrades Updated backfill tests to fix flyway migration version and update to stop relying on sql in DAOs since they change with future migrations Signed-off-by: Michael Collado <collado.mike@gmail.com> * Add comments to unit tests with fixed flyway migrations Signed-off-by: Michael Collado <collado.mike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes in the database schema can break the Java migration scripts if all flyway migrations are applied prior to running unit tests. This allows tests to specify fixed migration versions so that no future migrations are applied for that test. Also updated backfill tests to stop relying on sql in DAOs since they change with future migrations.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)