Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPADL conversion of Opta ball touches and recoveries #585

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

probberechts
Copy link
Member

  • The "ball recovery" event was previously discarded in the conversion to SPADL. It is now used to mark the start of a new dribble.
  • Opta inserts a "ball touch" event after passes that are deflected and sets the end location of the deflected pass to the location where it got deflected. As a consequence, a dribble event was added between the location where the ball was deflected and the start location of the next action in the SPADL version. This commit sets the end location of the deflected pass to the start location of the next action and the outcome to "success" if the deflected pass reached a teammate.

Fixes #519

@probberechts probberechts added the bug Something isn't working label Sep 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28% 🎉

Comparison is base (72aca85) 82.75% compared to head (baab157) 83.03%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   82.75%   83.03%   +0.28%     
==========================================
  Files          47       47              
  Lines        3374     3461      +87     
  Branches      563      596      +33     
==========================================
+ Hits         2792     2874      +82     
- Misses        491      493       +2     
- Partials       91       94       +3     
Files Changed Coverage Δ
socceraction/spadl/opta.py 92.80% <100.00%> (+1.20%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with dribble after ball touch (Opta)
2 participants