Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <long> nodes #27

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

cmandlbaur
Copy link
Contributor

Add support for the UseLong flag to optionally use <long> nodes instead of <i8> nodes.

Added tests where it seemed to make sense.

Fixed a couple of typos in the README

Add support for the `UseLong` flag to optionally use `<long>` nodes instead of `<i8>` nodes.

Added tests where it seemed to make sense.

Fixed a couple of typos in the README
@cmandlbaur
Copy link
Contributor Author

@LordVeovis it would be great if this could be included.

It's not really per the xmlrpc spec, but then neither was the i8 node.

It looks like the build failed to sign because of a login issue.

@LordVeovis LordVeovis added the enhancement New feature or request label Apr 16, 2024
@LordVeovis LordVeovis self-requested a review April 16, 2024 20:23
@LordVeovis
Copy link
Owner

Hey,

I saw your email, I am sorry for not responding here. Currently I do not have Internet at home so... I am not checking here very often as I do not use github at work.
On the paper it looks good.
For now, I have fixing CircleCI pieline and upgraded the project to something supported (.netcore3.1 -> .net 8.0) in the dev-circleci branch. So far so good and I hope to run your code with this base this week. If the tests are green, that should be enough.

So next steps:

  1. I run the tests locally
  2. If green, I merge dev-circleci on master
  3. After the fix, merge it.

Please ignore the Codacy issue.

@cmandlbaur
Copy link
Contributor Author

Thank you!

@LordVeovis LordVeovis merged commit 2fc19f6 into LordVeovis:master Apr 30, 2024
0 of 2 checks passed
@LordVeovis
Copy link
Owner

1.3.1 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants