-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: synthetic data generation cascade down topic tree #277
base: main
Are you sure you want to change the base?
Conversation
model_name: string, | ||
model_provider: string, | ||
) { | ||
// Add ignoring dupes and empty strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a plan to skip the duplicates?
{model} | ||
{num_samples_to_generate} | ||
{custom_topics_string} | ||
on_completed={handleGenerateSamplesCompleted} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if there’s a more idiomatic way in Svelte to control modal visibility (when the modal decides to close itself) than passing in a callback from the parent component like this
What does this PR do?
Add to all
buttons on theSynthetic data
page to let the user generate samples for every subtopic leaf descendant of a given topic node; I called that "Cascade mode"The parallelization is inspired by what was done for the
Save all
action; the error handling is similar. Tried to keep the workers' errors mapped to their topic so that if we want, we can later add something toTry again
and retry only the failed topics.Related Issues
N/A
Contributor License Agreement
I, @leonardmq, confirm that I have read and agree to the Contributors License Agreement.
Checklists