fix e_remove_serie_p when using serie_index #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- data.index was a typo, should be data.serie_index - checking for true (vs != null) misworks when serie_index = 0 (ie. first serie)
|
Added a very ugly fix (fe4b4e0) for removing series by name with radar plots and so on, but I'm really not sure about the possible side-effects. |
|
Thanks Robin! Could you please add yourself as contributor to the |
Done, thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with e_remove_serie that's discussed in #300 .
The only way atm to remove a radar serie is through the index, as the serie name does'nt work : with radar plots (and other array-based series structures), there is no
opts.series[[i]].name, as the series are arrays and their name are insideopts.series[[i]].data[[0]].name.