Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update student acceptance to backend changes #258

Merged
merged 3 commits into from
May 2, 2024

Conversation

Ahydul
Copy link
Contributor

@Ahydul Ahydul commented May 1, 2024

Added to the patch of student when accepting a student as admin the acceptance_date.

@Ahydul Ahydul linked an issue May 1, 2024 that may be closed by this pull request
@Ahydul Ahydul self-assigned this May 1, 2024
@Ahydul Ahydul requested a review from FelixoGudiel May 1, 2024 16:04
@Ahydul Ahydul added the bug Something isn't working label May 1, 2024
@Ahydul Ahydul added this to the PPL milestone May 1, 2024
@Ahydul Ahydul requested a review from claugp06 May 1, 2024 16:05
@FelixoGudiel
Copy link
Contributor

Please merge the latest changes form develop and indicate the process to check this feature

@Ahydul
Copy link
Contributor Author

Ahydul commented May 1, 2024

Please merge the latest changes form develop and indicate the process to check this feature

As a family user create a student in /familia/niños/registro
As an admin user accept the user in "/admin/familias/solicitudes"
In the backend check that the student is accepted and the accepted date is the actual date

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems working but I have a doubdt. If the accepted_date reaches a year does that student automatically stop being enroll? Because if not, it should be done like that

@Ahydul
Copy link
Contributor Author

Ahydul commented May 2, 2024

It seems working but I have a doubdt. If the accepted_date reaches a year does that student automatically stop being enroll? Because if not, it should be done like that

That is managed in the backend and it's supposed to work like that

@claugp06
Copy link
Collaborator

claugp06 commented May 2, 2024

It seems working but I have a doubdt. If the accepted_date reaches a year does that student automatically stop being enroll? Because if not, it should be done like that

That is managed in the backend and it's supposed to work like that

And in the backend once the time is exceeded it is delete it?

@Ahydul
Copy link
Contributor Author

Ahydul commented May 2, 2024

And in the backend once the time is exceeded it is delete it?

Like I said, that is how it is supposed to work (I understand the "delete" by not being enrolled..). I've obviously not tested it because that was not my job. If the backend was merged into develop then I suppose that it does indeed work.

@claugp06 claugp06 self-requested a review May 2, 2024 14:09
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected

Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@claugp06 claugp06 merged commit 5efc3eb into develop May 2, 2024
1 check passed
@claugp06 claugp06 deleted the fix/243-students-time-out branch May 2, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/243- Students-time-out
3 participants