-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update student acceptance to backend changes #258
Conversation
Please merge the latest changes form develop and indicate the process to check this feature |
As a family user create a student in /familia/niños/registro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems working but I have a doubdt. If the accepted_date reaches a year does that student automatically stop being enroll? Because if not, it should be done like that
That is managed in the backend and it's supposed to work like that |
And in the backend once the time is exceeded it is delete it? |
Like I said, that is how it is supposed to work (I understand the "delete" by not being enrolled..). I've obviously not tested it because that was not my job. If the backend was merged into develop then I suppose that it does indeed work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Added to the patch of student when accepting a student as admin the acceptance_date.