Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/253-Suggestions email #254

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix/253-Suggestions email #254

merged 2 commits into from
May 2, 2024

Conversation

FranciscoRossoR
Copy link
Contributor

Fixed the email field for suggestions so it can be null.
It still checks the format if something is submitted as an email.

@FranciscoRossoR FranciscoRossoR added the bug Something isn't working label Apr 29, 2024
@FranciscoRossoR FranciscoRossoR added this to the PPL milestone Apr 29, 2024
@FranciscoRossoR FranciscoRossoR self-assigned this Apr 29, 2024
@FranciscoRossoR FranciscoRossoR linked an issue Apr 29, 2024 that may be closed by this pull request
Fix/253-Suggestions-email #253
Closed
claugp06
claugp06 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

samrodman
samrodman approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@samrodman samrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done it appears to be working fine for me and it still checks the email once you type something

MartaInes
MartaInes approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@MartaInes MartaInes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! It works as expected

@MartaInes MartaInes merged commit 4f20de3 into develop May 2, 2024
1 check passed
@MartaInes MartaInes deleted the fix/253-suggestions-email branch May 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartaInes MartaInes MartaInes approved these changes

@samrodman samrodman samrodman approved these changes

@claugp06 claugp06 claugp06 approved these changes

Assignees

@FranciscoRossoR FranciscoRossoR

Labels
bug Something isn't working
Projects
None yet
Milestone
PPL
Development

Successfully merging this pull request may close these issues.

Fix/253-Suggestions-email
4 participants
@FranciscoRossoR @MartaInes @samrodman @claugp06