Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/167 family daily and yearly evaluation #206

Merged
merged 8 commits into from
Apr 17, 2024

Conversation

FelixoGudiel
Copy link
Contributor

As a family, you can now see the evaluations, both daily and yearly of your kids. Check the sections "Evaluación diaria" and "Evaluación anual" when logged as a family.

@FelixoGudiel FelixoGudiel linked an issue Apr 12, 2024 that may be closed by this pull request
@FelixoGudiel FelixoGudiel self-assigned this Apr 12, 2024
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table it not really resposive an the content it not shown in the best way:
image
But I like the approach of how the content it is display
Also change the route redirection when log in of family to evaluaciones diarias and I do not know why but the "Niños" navigation does not work

@FelixoGudiel
Copy link
Contributor Author

You are right. I have fixed the responsiveness and made it clearer for the user to understand the grade. Here are some examples:
image
image
If you are thinking about another aproach to the visualization of the evaluation, do tell me! I am taking as a base the figma mocks and the availible data system

@FelixoGudiel FelixoGudiel requested a review from claugp06 April 13, 2024 15:25
Ahydul
Ahydul previously approved these changes Apr 14, 2024
Copy link
Contributor

@Ahydul Ahydul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. I don't see any error.

claugp06
claugp06 previously approved these changes Apr 15, 2024
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected and the way the grades are shown makes it easier for the user to understand the system grade it has been used to evaluate their kids. Good job!

@FelixoGudiel FelixoGudiel dismissed stale reviews from claugp06 and Ahydul via ae225d8 April 17, 2024 10:51
@FelixoGudiel FelixoGudiel requested review from Ahydul and claugp06 April 17, 2024 10:56
@FelixoGudiel
Copy link
Contributor Author

Sorry, but merging changes have dismissed stale reviews. Please, check this branch and functionality again!

Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems working as expected

Copy link
Collaborator

@MartaInes MartaInes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working as it should. Good job!

@MartaInes MartaInes merged commit c165a13 into develop Apr 17, 2024
1 check passed
@MartaInes MartaInes deleted the feature/167-family-daily-and-yearly-evaluation branch April 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature/167- family daily and yearly evaluation
4 participants